On Sun, Feb 11, 2007 at 11:45:29PM +1100, Andrew Hood wrote:
New patch against 6570. There seems to be no reason to have the duplicate function definitions which upset the compiler. I got the inline to work and dropped those two functions from dstring.c since there should be no excuse for not inlining such simple functions.
Indeed they could probably be made macros.
#define dstring_str(ds) (ds ? ds->str : NULL) #define dstring_len(ds) (ds ? ds->len : 0)
Since the introduction of inline in C99, I tend to dislike macros (even though I agree that this is perhaps simple enough to qualify).
I did not update the makefile itself since most changes seem to reflect local preferences. But since I never use the makefile nor the README, I am happy to checkin whatever people who build on Windows using native tools agree on. (So far, I only cross-compiled binaries using the GNU tool chain.)
Which is why you aren't running into the MSVC "peculiarities".
Yes. I believe there is much more to be done to make things run nicer on Windows, such as reading MIB repository locations from the registry and such things. But I am simply not qualified to so any of this - so the only thing I could manage was to cross compile to help some friends who needed a version running on Win32. I happily accept patches...
/js