[libsmi] Error reporting with nested imports

27 Aug 2008


      In the error reporting function printError in error.c is this code:
if ((errors[i].level <= smiHandle->errorLevel) &&
        (parser->flags & SMI_FLAG_ERRORS) &&
        ((smiDepth == 1) || (parser->flags & SMI_FLAG_RECURSIVE))) {
        smiVasprintf(&buffer, errors[i].fmt, ap);
        (smiHandle->errorHandler) (parser->path, line,
    			       errors[i].level, buffer, errors[i].tag);
    }
The test for smiDepth means that when a module A imports from another
module B, errors while reading B are not reported. This may be reasonable
for harmless warnings, but if then B imports from a third module C, and
this module C isn't found, everything fails, probably with a segmentation
violation, and the user gets no indication of why.
I think the test
    (smiDepth == 1)
should be replaced with
    (smiDepth == 1 || errors[i].level <= 2)

[libsmi] Error reporting with nested imports

Arndt Jonasson