Re: [libsmi] libsmi-0.4.8:dump-cm.c:469:Same expression on both sides of '>'

On Mon, Dec 02, 2013 at 08:38:34PM +0000, David Binderman wrote:

Hello there,

I just ran the static analysis tool "cppcheck" over the source code of libsmi-0.4.8. It said

[dump-cm.c:469] -> [dump-cm.c:469]: (style) Same expression on both sides of '>'.

Source code is

if (x1 == x2 && y1> y1) con = 1;

I suspect

if (x1 == x2 && y1> y2) con = 1;

might be better code.

Yep. Fixed in the svn.

/js