Hello, previously I've reported on this mailing list about test failures. Now we've managed to localize them. So may be it's possible to fix some of them upstream?
1. smidump-sming test failure [1]. As Juergen told [2] it's Ok. Why don't you disable this test then? We already do this with the following command:
sed -i '/^[[:space:]]*smidump-sming.test \$/d' test/Makefile
2. smidump-orig-smiv2 failure[1]. This test failure caused by different locale settings and export LC_ALL=C fixes the problem [3]. May be it's good idea to add this into test suit itself?
3. smidump-cm fails. Initially it was reproduced on hppa, but later we found that it caused by compiler optimizations. So if you build with -Os or -O3 this test fails [4]. Now we forced building of libsmi only with -O2.
Will you accept patches for 1. and 2? Of course they are trivial... The test failure 3. is strange. Seems that code relies on some float pointing operations but code itself is not very reliable although I have not investigated it further and don't know where that code resides. What do you think?
[1] http://mail.ibr.cs.tu-bs.de/pipermail/libsmi/2008-March/001005.html [2] http://mail.ibr.cs.tu-bs.de/pipermail/libsmi/2008-March/001014.html [3] http://mail.ibr.cs.tu-bs.de/pipermail/libsmi/2008-March/001025.html [4] https://bugs.gentoo.org/show_bug.cgi?id=218541
On Sun, Nov 02, 2008 at 04:57:19PM +0300, Peter Volkov wrote:
Will you accept patches for 1. and 2? Of course they are trivial...
Sure.
The test failure 3. is strange. Seems that code relies on some float pointing operations but code itself is not very reliable although I have not investigated it further and don't know where that code resides. What do you think?
Good to know that this is compiler optimization related. Clearly, this should not happen and so this needs fixing - but now we know where to search (e.g. figuring out which specific optimization is causing this problem to occur).
/js
On Tue, Nov 04, 2008 at 05:29:47PM +0300, Peter Volkov wrote:
Both patches are in attachment.
[...]
Committed.
/js
Juergen,
I updated my subversion tree yesterday. gcc works fine, but cl (ms compiler, used fro windoz) compilation is broken. There are many errors in recent smi.c. cl is not a c99 compiler. Vars cannot be defined on the fly. I can email you the diff of the fixed smi.c
Thanks,
Yigal
---- Juergen Schoenwaelder j.schoenwaelder@jacobs-university.de wrote:
On Tue, Nov 04, 2008 at 05:29:47PM +0300, Peter Volkov wrote:
Both patches are in attachment.
[...]
Committed.
/js
-- Juergen Schoenwaelder Jacobs University Bremen gGmbH Phone: +49 421 200 3587 Campus Ring 1, 28759 Bremen, Germany Fax: +49 421 200 3103 http://www.jacobs-university.de/ -- !! This message is brought to you via the `libsmi' mailing list. !! Please do not reply to this message to unsubscribe. To unsubscribe or adjust !! your settings, send a mail message to libsmi-request@ibr.cs.tu-bs.de !! or look at https://mail.ibr.cs.tu-bs.de/mailman/listinfo/libsmi.
On Tue, Nov 04, 2008 at 04:14:08PM -0500, Yigal Hochberg wrote:
Juergen,
I updated my subversion tree yesterday. gcc works fine, but cl (ms compiler, used fro windoz) compilation is broken. There are many errors in recent smi.c. cl is not a c99 compiler. Vars cannot be defined on the fly. I can email you the diff of the fixed smi.c
Yes, please send me a diff. I will then also go over the new code snippets since I see also some other problems that should be fixed.
/js
Jens,
I use msvc 6.0 which is not c99. I think it will be good to be friendly for non-c99 compilers.
I will try 2005 if I can download it.
Thanks,
Yigal
---- Jens Engel jens.engel@ericsson.com wrote:
Yigal> cl is not a c99 compiler. Vars cannot be defined on the fly.
That pretty much depends which version of VisualStudio you are using. From VisualStudio2005 (for example Express Edition) on, the Microsoft compiler behaves pretty much like a c99 compiler:
- "Late declaration" like in C++ (not at begin of a block/function).
- inline keyword
- variadic preprocessor args
- ...
Earlier versions, for example VisualStudio6 pretty much behave like a C++ compiler with a little bit C support (or older C89? compiler support).
Ciao, Jens Engel
participants (3)
-
Juergen Schoenwaelder -
Peter Volkov -
Yigal Hochberg