Re: [libsmi] libsmi release 0.2.7

Yigal> On a slightly different topic:
Yigal> I added "-Wall -Wformat" to CFLAGS in tool/Makefile. Yigal> It looks like this:
Yigal> CFLAGS = -g -O2 -Wall -Wformat
Yigal> The -Wformat checks the validity of printfs syntax.
Yigal> I discovered several places with printf syntax problems. If you add Yigal> those flags and recompile you will see those warnings/errors.
Yigal> I suggest to add both flags as a standard to CFLAGS in Makefile. This Yigal> will help in creating a better quality source code.
I should keep in remind to usually add it to the --with-cflags options when I build using gcc. However, I did not add -Wall to the CFLAGS by default, because it's compiler specific. We could do it in cases where configure finds and uses gcc, but that would be just half of the story. BTW, -Wall includes -Wformat.
On which platform did you get the warnings? On Linux everything is fine. No warnings at all with -Wall. If your warnings appear on W32, could you please send me (not to the list) a dump of your make output? -- !! This message is brought to you via the `libsmi' mailing list. !! Please do not reply to this message to unsubscribe. To subscribe or !! unsubscribe, send a mail message to libsmi-request@ibr.cs.tu-bs.de. !! See http://www.ibr.cs.tu-bs.de/projects/libsmi/ for more information.
participants (1)
-
Frank Strauss