lib/parser-smi.c (and other generated files) in svn tree

Hi,
When doing a svn diff on the tree to generate a patch I found out that lib/parser-smi.c was actually checked in svn.
Shouldn't generated files being kept outside of the svn repo?
Luis

On Tue, Aug 21, 2007 at 10:05:33PM +0200, Luis EG Ontanon wrote:
When doing a svn diff on the tree to generate a patch I found out that lib/parser-smi.c was actually checked in svn.
Shouldn't generated files being kept outside of the svn repo?
In principle yes. But we also had times where different versions of bison generated sometimes broken code and where the .c files were actually nice to have in the SVN (not a strong argument, I know).
I leave it to Frank to decide whether he wants to change something.
/js

Juergen Schoenwaelder wrote:
On Tue, Aug 21, 2007 at 10:05:33PM +0200, Luis EG Ontanon wrote:
When doing a svn diff on the tree to generate a patch I found out that lib/parser-smi.c was actually checked in svn.
Shouldn't generated files being kept outside of the svn repo?
In principle yes. But we also had times where different versions of bison generated sometimes broken code and where the .c files were actually nice to have in the SVN (not a strong argument, I know).
I leave it to Frank to decide whether he wants to change something.
I'd like to stick with the current state, so that people with inappropriate versions of bison can still compile the code. Probably the situation became much better over the last few years, but on the other hand, it does not hurt to keep the bison-generated files in the repository.
participants (3)
-
Frank Strauß
-
Juergen Schoenwaelder
-
Luis EG Ontanon