Patches for building when srcdir != builddir
I am the Cygwin/X (http://xfree86.cygwin.com) maintainer and I am helping someone package libsmi for inclusion in the Cygwin distribution. I came across two instances in the source code that cause the build to fail when srcdir != builddir:
1) The files in libsmi/mibs/[iana,ietf,irtf,site,tubs] are not installed since the shell script magic returns no files in the builddir (the files reside in the srcdir instead).
2) The parser.test fails because the test files and MIBS files cannot be found.
I created two patches to fix these problems, hopefully without introducing other problems, that I would like to submit to the project. I have checked the latest CVS snapshot and it does not appear that these two issues have been fixed in CVS already. However, before I submit the patches I would like to know if people are interested in this sort of thing or if I should just sit on the patches.
Thanks,
Harold
Harold L Hunt writes:
[...]
Harold> I created two patches to fix these problems, hopefully without Harold> introducing other problems, that I would like to submit to the Harold> project. I have checked the latest CVS snapshot and it does Harold> not appear that these two issues have been fixed in CVS Harold> already. However, before I submit the patches I would like to Harold> know if people are interested in this sort of thing or if I Harold> should just sit on the patches.
I think we are (at least I am ;-) generally interested in patches and we will integrate them as long as we understand them and have a good feeling that they do not cause us trouble down the road.
/js
Juergen,
Juergen Schoenwaelder wrote:
Harold L Hunt writes:
[...]
Harold> I created two patches to fix these problems, hopefully without Harold> introducing other problems, that I would like to submit to the Harold> project. I have checked the latest CVS snapshot and it does Harold> not appear that these two issues have been fixed in CVS Harold> already. However, before I submit the patches I would like to Harold> know if people are interested in this sort of thing or if I Harold> should just sit on the patches.
I think we are (at least I am ;-) generally interested in patches and we will integrate them as long as we understand them and have a good feeling that they do not cause us trouble down the road.
Okay. I have to adapt my patches to the CVS version (I made them against 0.4.1), then test them again. I will send them in after that. It may be a few days since it is a holiday here (USA).
Harold
Harold L Hunt II wrote:
Juergen Schoenwaelder wrote:
I think we are (at least I am ;-) generally interested in patches and we will integrate them as long as we understand them and have a good feeling that they do not cause us trouble down the road.
Okay. I have to adapt my patches to the CVS version (I made them against 0.4.1), then test them again. I will send them in after that. It may be a few days since it is a holiday here (USA).
I agree to Jürgen's statement. I would be happy to integrate patches that help to keep the dissemination of required patches limited where it's easily possible.
Looking forward to your patches...
-frank
participants (3)
-
Frank Strauß -
Harold L Hunt II -
Juergen Schoenwaelder