libsmi 0.4.4: building problems
Hi,
This is a report of two building problems that make the building process fail, a report of test failures and a small patch to the man pages:
1) build failure due to missing file
The latest version of libsmi (0.4.4) fails to build due to a missing file - dump-svg-script-js. This file hasn't been included in the libsmi-0.4.4 tarball but exists in svn.
2) build failure due to FORTIFY_SOURCE
This version of libsmi (and at the least 0.4.3) also fail to build in Fedora Core 4 and Fedora Core 5 systems if we use the same CFLAGS as in the base distro. This failure is due to FORTIFY_SOURCE, a buffer overflow prevention/detection mechanism built in gcc and glibc. This mechanism replaces almost all C library functions that deal with buffer copies, namely snprintf. The attached patch - libsmi-0.4.3-snprintf.h.patch - fixes this problem.
3) test failures
The "make check" step reports two test failures.
4) man pages
The second patch - libsmi-0.4.4-lib-manpages.patch - just replaces the pattern "@prefix@/include" by "@includedir@" in several man pages.
Regards, jpo
Jose Pedro Oliveira schrieb:
Hi,
Hi,
This is a report of two building problems that make the building process fail, a report of test failures and a small patch to the man pages:
- build failure due to missing file
The latest version of libsmi (0.4.4) fails to build due to a missing file - dump-svg-script-js. This file hasn't been included in the libsmi-0.4.4 tarball but exists in svn.
I /think/ Frank wanted to omit the step dump-svg-script.js -> dump-svg-script.h in the release and therefore included dump-svg-script.h But we need to adjust the Makefile as well. The attached patch works fine for me. Frank, could you please have a look at it.
Kind regards, Klaus Sperner
diff -ruN libsmi-0.4.4-orig/tools/Makefile.am libsmi-0.4.4/tools/Makefile.am --- libsmi-0.4.4-orig/tools/Makefile.am 2005-11-25 10:14:00.000000000 +0100 +++ libsmi-0.4.4/tools/Makefile.am 2006-05-28 21:54:38.000000000 +0200 @@ -30,9 +30,6 @@ smilint_SOURCES = smilint.c shhopt.c smilint_LDADD = ../lib/libsmi.la
-dump-svg-script.h: dump-svg-script.js - (echo "const char *code =";cat dump-svg-script.js | sed -e 's/\/&&/g;s/"/\"/g;s/^/"/;s/$$/\n"/'; echo ";") > dump-svg-script.h - dump-svg.o: dump-svg-script.h
smidump_SOURCES = smidump.c smidump.h shhopt.c \ @@ -48,5 +45,3 @@
smidiff_SOURCES = smidiff.c shhopt.c smidiff_LDADD = ../lib/libsmi.la - -MOSTLYCLEANFILES = dump-svg-script.h diff -ruN libsmi-0.4.4-orig/tools/Makefile.in libsmi-0.4.4/tools/Makefile.in --- libsmi-0.4.4-orig/tools/Makefile.in 2006-05-16 12:49:32.000000000 +0200 +++ libsmi-0.4.4/tools/Makefile.in 2006-05-28 21:54:52.000000000 +0200 @@ -274,7 +274,6 @@ smidump_LDADD = ../lib/libsmi.la -lm smidiff_SOURCES = smidiff.c shhopt.c smidiff_LDADD = ../lib/libsmi.la -MOSTLYCLEANFILES = dump-svg-script.h all: all-am
.SUFFIXES: @@ -674,9 +673,6 @@ uninstall-man1
-dump-svg-script.h: dump-svg-script.js - (echo "const char *code =";cat dump-svg-script.js | sed -e 's/\/&&/g;s/"/\"/g;s/^/"/;s/$$/\n"/'; echo ";") > dump-svg-script.h - dump-svg.o: dump-svg-script.h # Tell versions [3.59,3.63) of GNU make to not export all variables. # Otherwise a system limit (for SysV at least) may be exceeded.
participants (2)
-
Jose Pedro Oliveira -
Klaus Sperner