libsmi-0.4.8:dump-cm.c:469:Same expression on both sides of '>'
2 Dec
2013
2 Dec
'13
9:38 p.m.
Hello there,
I just ran the static analysis tool "cppcheck" over the source code of libsmi-0.4.8. It said
[dump-cm.c:469] -> [dump-cm.c:469]: (style) Same expression on both sides of '>'.
Source code is
if (x1 == x2 && y1> y1) con = 1;
I suspect
if (x1 == x2 && y1> y2) con = 1;
might be better code.
Regards
David Binderman
2 Dec
2 Dec
9:50 p.m.
New subject: libsmi-0.4.8:dump-cm.c:469:Same expression on both sides of '>'
On Mon, Dec 02, 2013 at 08:38:34PM +0000, David Binderman wrote:
Hello there,
I just ran the static analysis tool "cppcheck" over the source code of libsmi-0.4.8. It said
[dump-cm.c:469] -> [dump-cm.c:469]: (style) Same expression on both sides of '>'.
Source code is
if (x1 == x2 && y1> y1) con = 1;
I suspect
if (x1 == x2 && y1> y2) con = 1;
might be better code.
Yep. Fixed in the svn.
/js
--
Juergen Schoenwaelder Jacobs University Bremen gGmbH
Phone: +49 421 200 3587 Campus Ring 1, 28759 Bremen, Germany
Fax: +49 421 200 3103 http://www.jacobs-university.de/
4180
Age (days ago)
4180
Last active (days ago)
1 comments
2 participants
participants (2)
-
David Binderman -
Juergen Schoenwaelder