January 2012 - Libsmi - lists.ibr.cs.tu-bs.de

smidump --format=smiv2 output contains some errors in compliance SYNTAX/WRITE-SYNTAX clauses.
by Jens Engel 06 Jun '13

06 Jun '13

Hello, I just stumbled over the following problem in libsmi 0.4.8 and development trunk-tip rev34557 (as of today). The problem resides in the SYNTAX/WRITE-SYNTAX clauses in COMPLIANCE statements. Instead of a "type" the invalid term "(null)" is present. AFFECTED-MIBS (at least): - BRIDGE-MIB - SNMP-VIEW-BASED-ACM-MIB - ... => grep "(null)" *-MIB EXAMPLE: smidump --format=smiv2 BRIDGE-MIB ... OBJECT dot1dStpPriority SYNTAX (null) (0 | 4096 | 8192 | 12288 | 16384 | 20480 | 24576 | 28672 | 32768 | 36864 | 40960 | 45056 | 49152 | 53248 | 57344 | 61440) ... OBJECT dot1dStpPortPriority SYNTAX (null) (0 | 16 | 32 | 48 | 64 | 80 | 96 | 112 | 128 | 144 | 160 | 176 | 192 | 208 | 224 | 240) BUT: Original BRIDGE-MIB that is distributed w/ libsmi contains: OBJECT dot1dStpPriority SYNTAX Integer32 (0 | 4096 | 8192 | 12288 | 16384 | 20480 | 24576 | 28672 | 32768 | 36864 | 40960 | 45056 | 49152 | 53248 | 57344 | 61440) ... OBJECT dot1dStpPortPriority SYNTAX Integer32 (0 | 16 | 32 | 48 | 64 | 80 | 96 | 112 | 128 | 144 | 160 | 176 | 192 | 208 | 224 | 240) smidump --format=smiv2 SNMP-VIEW-BASED-ACM-MIB ... OBJECT vacmViewTreeFamilyMask WRITE-SYNTAX (null) (SIZE(0)) ... SHOULD-BE (as in original MIB distributed with libsmi): ... OBJECT vacmViewTreeFamilyMask WRITE-SYNTAX OCTET STRING (SIZE(0)) I assume that smidump does not have the info (only a NULL pointer) and just dumps it as textual info. NOTE: "smidiff <ORIGINAL-MIB> <SMIDUMPED-MIB>" does not seem to show a difference (except warnings, ...). Ciao, Jens

3 2

Lost patch: parse all our mibs (fwd)
by Marcin Cieslak 12 Jan '12

12 Jan '12

did you mean this? //Marcin ---------- Forwarded message ---------- Date: Fri, 6 Jan 2012 23:40:26 From: Koen Van Hoof <koen.van_hoof(a)alcatel-lucent.com> To: "libsmi(a)ibr.cs.tu-bs.de" <libsmi(a)ibr.cs.tu-bs.de> Subject: [libsmi] parse all our mibs Hi, In order to be able to parse all our mibs, I have made some changes to libsmi. Here are my proposed changes. (See attached patches). 1) I have added SMI_ACCESS_WRITE_ONLY, because in SMIv1 this is also a valid access. 2) I have added SMI_BASETYPE_CHOICE. If the CHOICE type was SMI_BASETYPE_UNKNOWN, an import of that type caused a failure. 3) For the enum values of SMI_BASETYPE_ENUM, also the lists of the parent types are checked. 4) In SMIv1 'INTEGER(0..4294967295)' is vallid. In order to be able to parse this, a selection between SMI_BASETYPE_INTEGER32, SMI_BASETYPE_UNSIGNED64 and SMI_BASETYPE_UNSIGNED32 is made, based on the range of the integerSubType. 5) For SMIv1, the status 'mandatory', 'deprecated', 'obsolete' and 'optional' are parsed, and set to SMI_STATUS_MANDATORY, SMI_STATUS_DEPRECATED, SMI_STATUS_OBSOLETE and SMI_STATUS_OPTIONAL. 6) I have changed the check '(a->value.unsigned32> 1)&& (a->value.unsigned32-1> 2147483647))' into '(a->value.unsigned32>= 0x80000000u)'. This does not give any overflow, because it's an unsigned comparison (Notice the 'u' at the end of 0x80000000u. 7) In the last if statement, the result of compareValues was wrong, the parameters of the subtraction had to be switched. I have tested this with 'smi_dump -f xml' and the output is much better now. I hope my changes can contribute. :-) Koen Van Hoof -- !! This message is brought to you via the `libsmi' mailing list. !! Please do not reply to this message to unsubscribe. To unsubscribe or adjust !! your settings, send a mail message to <libsmi-request(a)ibr.cs.tu-bs.de> !! or look at https://www.ibr.cs.tu-bs.de/mailman/listinfo/libsmi.

2 1

lost patch
by Juergen Schoenwaelder 11 Jan '12

11 Jan '12

Hi, a few days ago someone submitted a longer patch to me personally and I might have accidentally lost the message. If you submitted a patch recently, please resubmit. Sorry for the inconvenience. /js -- Juergen Schoenwaelder Jacobs University Bremen gGmbH Phone: +49 421 200 3587 Campus Ring 1, 28759 Bremen, Germany Fax: +49 421 200 3103 <http://www.jacobs-university.de/>

1 0

parse all our mibs
by Koen Van Hoof 07 Jan '12

07 Jan '12

Hi, In order to be able to parse all our mibs, I have made some changes to libsmi. Here are my proposed changes. (See attached patches). 1) I have added SMI_ACCESS_WRITE_ONLY, because in SMIv1 this is also a valid access. 2) I have added SMI_BASETYPE_CHOICE. If the CHOICE type was SMI_BASETYPE_UNKNOWN, an import of that type caused a failure. 3) For the enum values of SMI_BASETYPE_ENUM, also the lists of the parent types are checked. 4) In SMIv1 'INTEGER(0..4294967295)' is vallid. In order to be able to parse this, a selection between SMI_BASETYPE_INTEGER32, SMI_BASETYPE_UNSIGNED64 and SMI_BASETYPE_UNSIGNED32 is made, based on the range of the integerSubType. 5) For SMIv1, the status 'mandatory', 'deprecated', 'obsolete' and 'optional' are parsed, and set to SMI_STATUS_MANDATORY, SMI_STATUS_DEPRECATED, SMI_STATUS_OBSOLETE and SMI_STATUS_OPTIONAL. 6) I have changed the check '(a->value.unsigned32> 1)&& (a->value.unsigned32-1> 2147483647))' into '(a->value.unsigned32>= 0x80000000u)'. This does not give any overflow, because it's an unsigned comparison (Notice the 'u' at the end of 0x80000000u. 7) In the last if statement, the result of compareValues was wrong, the parameters of the subtraction had to be switched. I have tested this with 'smi_dump -f xml' and the output is much better now. I hope my changes can contribute. :-) Koen Van Hoof

1 0