- Libsmi - lists.ibr.cs.tu-bs.de

[PATCH] Fix build failure with gcc-15
by mark.yang＠lge.com 07 Apr '25

07 Apr '25

[PATCH] Fix build failure with gcc-15 * see more details: http://errors.yoctoproject.org/Errors/Details/851179/ yang-data.c:594:9: error: too many arguments to function 'yangparse'; expected 0, have 1 594 | yangparse(parser); | ^~~~~~~~~ ~~~~~~ In file included from scanner-yang.h:19, from yang-data.c:47: parser-yang.h:16:12: note: declared here 16 | extern int yangparse(); | ^~~~~~~~~ In file included from parser-yang.c:346: parser-yang.tab.h:170:5: error: conflicting types for 'yangparse'; have 'int(struct Parser *)' 170 | int yangparse (struct Parser *parserPtr); | ^~~~~~~~~ In file included from parser-yang.y:40: parser-yang.h:16:12: note: previous declaration of 'yangparse' with type 'int(void)' 16 | extern int yangparse(); | ^~~~~~~~~ make[2]: *** [Makefile:573: yang-data.lo] Error 1 make[2]: *** Waiting for unfinished jobs.... smi-data.c: In function 'loadModule': smi-data.c:4658:9: error: too many arguments to function 'smiparse'; expected 0, have 1 4658 | smiparse((void *)&parser); | ^~~~~~~~ ~~~~~~~~~~~~~~~ smi-data.c:42:12: note: declared here 42 | extern int smiparse(); | ^~~~~~~~ parser-smi.c:1515:5: error: conflicting types for 'smiparse'; have 'int(struct Parser *)' 1515 | int smiparse (struct Parser *parserPtr); | ^~~~~~~~ In file included from parser-smi.y:37: parser-smi.h:27:12: note: previous declaration of 'smiparse' with type 'int(void)' 27 | extern int smiparse(); | ^~~~~~~~ parser-smi.c:63:25: error: conflicting types for 'smiparse'; have 'int(struct Parser *)' 63 | #define yyparse smiparse | ^~~~~~~~ parser-smi.c:3207:1: note: in expansion of macro 'yyparse' 3207 | yyparse (struct Parser *parserPtr) | ^~~~~~~ parser-smi.h:27:12: note: previous declaration of 'smiparse' with type 'int(void)' 27 | extern int smiparse(); | ^~~~~~~~ parser-yang.c:68:25: error: conflicting types for 'yangparse'; have 'int(struct Parser *)' 68 | #define yyparse yangparse | ^~~~~~~~~ parser-yang.c:2312:1: note: in expansion of macro 'yyparse' 2312 | yyparse (struct Parser *parserPtr) | ^~~~~~~ parser-yang.h:16:12: note: previous declaration of 'yangparse' with type 'int(void)' 16 | extern int yangparse(); | ^~~~~~~~~ In file included from scanner-yang.l:31: parser-yang.tab.h:170:5: error: conflicting types for 'yangparse'; have 'int(struct Parser *)' 170 | int yangparse (struct Parser *parserPtr); | ^~~~~~~~~ In file included from scanner-yang.l:30: parser-yang.h:16:12: note: previous declaration of 'yangparse' with type 'int(void)' 16 | extern int yangparse(); | ^~~~~~~~~ scanner-yang.l: In function 'yangEnterLexRecursion': scanner-yang.l:79:1: warning: old-style function definition [-Wold-style-definition] 79 | | ^ make[2]: *** [Makefile:573: smi-data.lo] Error 1 In file included from parser-smi.y:36: parser-smi.c: In function 'smiparse': parser-smi.c:10265:29: warning: passing argument 1 of 'smiyyerror' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 10265 | yyerror (parserPtr, yymsgp); | ^~~~~~ error.h:25:44: note: in definition of macro 'yyerror' 25 | #define yyerror(parserPtr, msg) smiyyerror(msg, parserPtr) | ^~~ In file included from parser-smi.y:40: smi-check.h:71:30: note: expected 'char *' but argument is of type 'const char *' 71 | extern void smiyyerror(char *msg, Parser *parserPtr); | ~~~~~~^~~ make[2]: *** [Makefile:573: parser-yang.lo] Error 1 make[2]: *** [Makefile:573: parser-smi.lo] Error 1 make[2]: *** [Makefile:573: scanner-yang.lo] Error 1 In file included from scanner-smi.l:34: parser-smi.tab.h:192:5: error: conflicting types for 'smiparse'; have 'int(struct Parser *)' 192 | int smiparse (struct Parser *parserPtr); | ^~~~~~~~ In file included from util.h:22, from scanner-smi.l:32: parser-smi.h:27:12: note: previous declaration of 'smiparse' with type 'int(void)' 27 | extern int smiparse(); | ^~~~~~~~ scanner-smi.l: In function 'smiEnterLexRecursion': scanner-smi.l:76:1: warning: old-style function definition [-Wold-style-definition] 76 | smiEnterLexRecursion(file) | ^~~~~~~~~~~~~~~~~~~~ Signed-off-by: mark.yang <mark.yang(a)lge.com> --- lib/parser-smi.h | 2 +- lib/parser-yang.h | 4 ++-- lib/smi-data.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/parser-smi.h b/lib/parser-smi.h index 90d7ec2..c2a3d1f 100644 --- a/lib/parser-smi.h +++ b/lib/parser-smi.h @@ -24,7 +24,7 @@ -extern int smiparse(); +extern int smiparse(struct Parser *parserPtr); diff --git a/lib/parser-yang.h b/lib/parser-yang.h index dbfec46..f008cd6 100644 --- a/lib/parser-yang.h +++ b/lib/parser-yang.h @@ -6,14 +6,14 @@ #include <stdio.h> #include "yang-data.h" - +#include "smi-data.h" #define YYERROR_VERBOSE -extern int yangparse(); +extern int yangparse(struct Parser *parserPtr); diff --git a/lib/smi-data.c b/lib/smi-data.c index c9d95a4..773bc01 100644 --- a/lib/smi-data.c +++ b/lib/smi-data.c @@ -39,7 +39,7 @@ #ifdef BACKEND_SMI #include "scanner-smi.h" -extern int smiparse(); +extern int smiparse(struct Parser *parserPtr); #endif #ifdef BACKEND_SMING

1 0

[PATCH] Fix build failure with gcc-15
by mark.yang＠lge.com 07 Apr '25

07 Apr '25

From: "mark.yang" <mark.yang(a)lge.com> * see more details: http://errors.yoctoproject.org/Errors/Details/851179/ yang-data.c:594:9: error: too many arguments to function 'yangparse'; expected 0, have 1 594 | yangparse(parser); | ^~~~~~~~~ ~~~~~~ In file included from scanner-yang.h:19, from yang-data.c:47: parser-yang.h:16:12: note: declared here 16 | extern int yangparse(); | ^~~~~~~~~ In file included from parser-yang.c:346: parser-yang.tab.h:170:5: error: conflicting types for 'yangparse'; have 'int(struct Parser *)' 170 | int yangparse (struct Parser *parserPtr); | ^~~~~~~~~ In file included from parser-yang.y:40: parser-yang.h:16:12: note: previous declaration of 'yangparse' with type 'int(void)' 16 | extern int yangparse(); | ^~~~~~~~~ make[2]: *** [Makefile:573: yang-data.lo] Error 1 make[2]: *** Waiting for unfinished jobs.... smi-data.c: In function 'loadModule': smi-data.c:4658:9: error: too many arguments to function 'smiparse'; expected 0, have 1 4658 | smiparse((void *)&parser); | ^~~~~~~~ ~~~~~~~~~~~~~~~ smi-data.c:42:12: note: declared here 42 | extern int smiparse(); | ^~~~~~~~ parser-smi.c:1515:5: error: conflicting types for 'smiparse'; have 'int(struct Parser *)' 1515 | int smiparse (struct Parser *parserPtr); | ^~~~~~~~ In file included from parser-smi.y:37: parser-smi.h:27:12: note: previous declaration of 'smiparse' with type 'int(void)' 27 | extern int smiparse(); | ^~~~~~~~ parser-smi.c:63:25: error: conflicting types for 'smiparse'; have 'int(struct Parser *)' 63 | #define yyparse smiparse | ^~~~~~~~ parser-smi.c:3207:1: note: in expansion of macro 'yyparse' 3207 | yyparse (struct Parser *parserPtr) | ^~~~~~~ parser-smi.h:27:12: note: previous declaration of 'smiparse' with type 'int(void)' 27 | extern int smiparse(); | ^~~~~~~~ parser-yang.c:68:25: error: conflicting types for 'yangparse'; have 'int(struct Parser *)' 68 | #define yyparse yangparse | ^~~~~~~~~ parser-yang.c:2312:1: note: in expansion of macro 'yyparse' 2312 | yyparse (struct Parser *parserPtr) | ^~~~~~~ parser-yang.h:16:12: note: previous declaration of 'yangparse' with type 'int(void)' 16 | extern int yangparse(); | ^~~~~~~~~ In file included from scanner-yang.l:31: parser-yang.tab.h:170:5: error: conflicting types for 'yangparse'; have 'int(struct Parser *)' 170 | int yangparse (struct Parser *parserPtr); | ^~~~~~~~~ In file included from scanner-yang.l:30: parser-yang.h:16:12: note: previous declaration of 'yangparse' with type 'int(void)' 16 | extern int yangparse(); | ^~~~~~~~~ scanner-yang.l: In function 'yangEnterLexRecursion': scanner-yang.l:79:1: warning: old-style function definition [-Wold-style-definition] 79 | | ^ make[2]: *** [Makefile:573: smi-data.lo] Error 1 In file included from parser-smi.y:36: parser-smi.c: In function 'smiparse': parser-smi.c:10265:29: warning: passing argument 1 of 'smiyyerror' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 10265 | yyerror (parserPtr, yymsgp); | ^~~~~~ error.h:25:44: note: in definition of macro 'yyerror' 25 | #define yyerror(parserPtr, msg) smiyyerror(msg, parserPtr) | ^~~ In file included from parser-smi.y:40: smi-check.h:71:30: note: expected 'char *' but argument is of type 'const char *' 71 | extern void smiyyerror(char *msg, Parser *parserPtr); | ~~~~~~^~~ make[2]: *** [Makefile:573: parser-yang.lo] Error 1 make[2]: *** [Makefile:573: parser-smi.lo] Error 1 make[2]: *** [Makefile:573: scanner-yang.lo] Error 1 In file included from scanner-smi.l:34: parser-smi.tab.h:192:5: error: conflicting types for 'smiparse'; have 'int(struct Parser *)' 192 | int smiparse (struct Parser *parserPtr); | ^~~~~~~~ In file included from util.h:22, from scanner-smi.l:32: parser-smi.h:27:12: note: previous declaration of 'smiparse' with type 'int(void)' 27 | extern int smiparse(); | ^~~~~~~~ scanner-smi.l: In function 'smiEnterLexRecursion': scanner-smi.l:76:1: warning: old-style function definition [-Wold-style-definition] 76 | smiEnterLexRecursion(file) | ^~~~~~~~~~~~~~~~~~~~ Signed-off-by: mark.yang <mark.yang(a)lge.com> --- lib/parser-smi.h | 2 +- lib/parser-yang.h | 4 ++-- lib/smi-data.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/parser-smi.h b/lib/parser-smi.h index 90d7ec2..c2a3d1f 100644 --- a/lib/parser-smi.h +++ b/lib/parser-smi.h @@ -24,7 +24,7 @@ -extern int smiparse(); +extern int smiparse(struct Parser *parserPtr); diff --git a/lib/parser-yang.h b/lib/parser-yang.h index dbfec46..f008cd6 100644 --- a/lib/parser-yang.h +++ b/lib/parser-yang.h @@ -6,14 +6,14 @@ #include <stdio.h> #include "yang-data.h" - +#include "smi-data.h" #define YYERROR_VERBOSE -extern int yangparse(); +extern int yangparse(struct Parser *parserPtr); diff --git a/lib/smi-data.c b/lib/smi-data.c index c9d95a4..773bc01 100644 --- a/lib/smi-data.c +++ b/lib/smi-data.c @@ -39,7 +39,7 @@ #ifdef BACKEND_SMI #include "scanner-smi.h" -extern int smiparse(); +extern int smiparse(struct Parser *parserPtr); #endif #ifdef BACKEND_SMING

1 0

Supressing the implicit function declaration warning
by Joar Heimonen 16 Jul '24

16 Jul '24

C99 - C11 does not allow implicit function declarations by default, this stops lib/yang-complex-types.c from compiling. Pulling the [changes](https://github.com/Slenderman00/LibSMI/commit/eb7ddd9d9a4db4f5e4fb… from https://github.com/Slenderman00/LibSMI fixes the issue. My fork simply suppresses the error. Joar Heimonen Developer UiT ITA Joar.me

1 0

[PATCH] Add .gitignore file
by Enji Cooper 06 Jun '24

06 Jun '24

Hi, The attached patch proposes a .gitignore file be added to avoid potentially adding files to the git repo which are generated as part of the overall build process. Please let me know if I need to do anything else when submitting patches. Thank you! -Enji

1 0

[PATCH] Some Coverity fixes for strtok(..) use
by Enji Cooper 06 Jun '24

06 Jun '24

Hi there! I have 2 patches attached which help resolve some basic concerns around memory management dealing with results from strtok, etc. Thank you, -Enji

1 0

Maintaining https://gitlab.ibr.cs.tu-bs.de/nm/libsmi
by Marek Hajduczenia 04 Apr '24

04 Apr '24

Good afternoon, Libsmi distro I have code to contribute to the libsmi library. During the development of one of IEEE 802.3.1 standard revisions, a need for the configurable control of the line width became apparent to reprint existing MIBs into a line-width controlled format (via smidump). The parameter controlling the line width is hard coded right now so I have extended the existing parameter set with -w (--width) parametrization, which allows to set the line width for multiline printing function. I also had to rewrite the multiline printing function to properly account for whole word delimiters to provide a more visually acceptable output. I have modified code available for review (there are in total 5-6 files I had to touch). The code is written in C and compiled on Ubuntu 22.04 with all latest libraries for test purposes. What would be the best way to share the code, have it reviewed, and perhaps pulled into the GIT repository? My goal, at the end of the day, is to make sure that the updated code with -w parameter support is included in future Linux distros, to facilitate SMIv2 code development for folks. Regards Marek Hajduczenia

1 0

C99 compatibility fixes
by Florian Weimer 14 Apr '23

14 Apr '23

libsmi 0.4.8 in Fedora needs the attached patches to keep building with future compilers that are more strict regarding the C99 language version. Related to: <https://fedoraproject.org/wiki/Changes/PortingToModernC> <https://fedoraproject.org/wiki/Toolchain/PortingToModernC> Thanks, Florian

1 0

RFC-1212 inclusion in libsmi
by Nathan Ward 25 Jan '22

25 Jan '22

Hi, RFC-1212 includes some examples. These examples have been included as part of libsmi along with other MIBs, presumably as a result of smistrip or similar. My belief is that it should not be included - as RFC-1212 is only examples. Would you accept a patch removing RFC-1212 from libsmi? -- Nathan Ward

2 1

Subversion server down?
by Gerald Combs 15 Jan '21

15 Jan '21

Hi, I'm attempting to check out the libsmi SVN trunk, but unfortunately the server appears to be down: $ svn co http://svn.ibr.cs.tu-bs.de/software-ibr-1999-libsmi/trunk libsmi svn: E170013: Unable to connect to a repository at URL 'http://svn.ibr.cs.tu-bs.de/software-ibr-1999-libsmi/trunk' svn: E120108: Error running context: The server unexpectedly closed the connection. $ curl -I http://svn.ibr.cs.tu-bs.de/software-ibr-1999-libsmi curl: (7) Failed to connect to svn.ibr.cs.tu-bs.de port 80: Connection refused

3 3

Insufficient buffer length in getStringIndexList() in smidiff.c
by Nathan Kitchen 07 Jan '19

07 Jan '19

In smidiff.c, in the function getStringIndexList(), the realloc() call for strIdxList adds 4, which matches the number of literal characters in the format string in the subsequent sprintf() call, but it doesn't account for the terminating null byte. It should be "+ 5". I suspect that most runs of smidiff don't get memory corruption from the buffer overrun because realloc() usually happens to allocate a memory block larger than requested (e.g., the next larger power of 2). -- Nathan

2 1