- Libsmi - lists.ibr.cs.tu-bs.de

Perl dumper creates malformed code for malformed IMPORTS
by Bill Fenner 21 Mar '07

21 Mar '07

I know, I know, GIGO, and why am I using -k? (I am using -k because some of the problems that force using -k will still produce perfectly useful output. I suspect fixing this would require re-evaluating the severity of quite a few errors; using -k is way easier.)) I have several poorly-extracted MIBs where an I-D header ended up in the middle of the IMPORTS clause, causing a syntax error and several smiImport data structures with a null module ID. Since lastModule==NULL was used as a flag for "did I ever print anything", and strcmp has unpredictable handling for being passed NULL, I just skipped the inside of the loop if the current import's module is NULL. Diff follows. Bill --- dump-perl.c (revision 6635) +++ dump-perl.c (working copy) @@ -617,11 +617,12 @@ for (i = 0, smiImport = smiGetFirstImport(smiModule); smiImport; i++, - lastModule = smiImport->module, smiImport = smiGetNextImport(smiImport)) { if (i == 0) { fprintSegment(f, INDENT, "\"imports\" => [\n", 0); } + if (smiImport->module == NULL) + continue; if ( lastModule == NULL || strcmp(lastModule, smiImport->module)) { if ( lastModule ) { @@ -636,6 +637,7 @@ } fprintSegment(f, 4 * INDENT, "", 0); fprint(f, "\"%s\",\n", smiImport->name); + lastModule = smiImport->module; } if (lastModule) { fprintSegment(f, 3 * INDENT, "],\n", 0);

2 1

Perl dumper truncates DEFVALs with lots of BITS, causing perl syntax errors
by Bill Fenner 13 Mar '07

13 Mar '07

There are two fixed-size buffers in this code path: - getValueString's s[100]. This one is gaily overflowed, with sprintf(&s[strlen(s)], ...) - fprint's s[200]. This one is not overflowed, but this overflow causes the syntax error, since fprint(f, "\"%s\"", getValueString(smiValue, smiType)); loses the trailing quote. My workaround was to change them to s[500] and s[1000], respectively. A more robust workaround might be to output the trailing quote with a different fprint() call, so that a too-long value creates a valid perl program with invalid data. (I don't know if that's better or worse.) If vasprintf() is available, fprint could use that to avoid a fixed-length buffer. I don't have any suggestions for getValueString's fixed-length buffer. A good test case is POLICY-BASED-MANAGEMENT-MIB (RFC 4011)'s pmSchedDay. Bill

2 1

Need some help regarding with smidiff.
by RAGHAVENDRA KRISTAM 23 Feb '07

23 Feb '07

Hi Libsmi Team, If any MIB imported an Unsigned64 object from CISCO-TC MIB, no differences are getting even though differences exists when I use smidiff for two mibs . In remaining cases smidiff is working fine. Please let me know how to solve this problem. Thanks, Raghavendra.

4 13

using libsmi with vxWorks?
by Frank Marcotullio 12 Feb '07

12 Feb '07

Hello, Has anyone compiled and used libsmi with vxWorks? If so, any details that you can share? Thank you, ******************************************************** * * Frank Marcotullio II * Senior Software Engineer * Aerotek Contract Engineering - onsite at: * * Interface Control Systems * 8945 Guilford Rd., Suite 120 * Columbia, MD 21046 * * phone:(410) 290-7600 ext. 13 * * email: frank.marcotullio(a)interfacecontrol.com * ********************************************************

1 0

More malformed patterns using -f xsd
by Arndt Jonasson 13 Sep '06

13 Sep '06

I use libsmi 0.4.5. When I have a textual convention like this one: 1) NiceString1 ::= TEXTUAL-CONVENTION DISPLAY-HINT "2d" STATUS current DESCRIPTION "doc" SYNTAX OCTET STRING (SIZE (2)) the pattern which "dumpsmi -f xsd" translates the display hint into is: ((0|[1-9]([0-9]{0,5})) which has unbalanced parentheses. I think that line 655 smiAsprintf( &ret, "%s(0|[1-9]([0-9]{0,%d})", should be smiAsprintf( &ret, "%s(0|[1-9]([0-9]{0,%d}))", 2) Similar problem here: NiceString2 ::= TEXTUAL-CONVENTION DISPLAY-HINT "4d" STATUS current DESCRIPTION "doc" SYNTAX OCTET STRING (SIZE (0..2 | 4..5)) The pattern: (((0|[1-9]([0-9]{0,5}))|((0|[1-9]([0-9]{0,10}))) I think that line 726 if( ! lengths[ i - 2 ] ) { should be if( ! lengths[0] ) { (The fix from problem 2 is needed too here.) 3) A third problem with patterns from display hints is that a period (.) is not always escaped with a backslash (\.) (for example with the display hint "1x."). My suggested fix is to use a two-character char array for 'separator', and insert the '\' already when the separator is set from the hint. Then no tests are needed further down, but the %c changed to %s.

2 2

Patch to autogen.sh to build on MaxOS X
by Sebastian Strollo 06 Sep '06

06 Sep '06

Hi On Darwin (MacOS X) the GNU libtool is installed as "glibtool", I attach a suggested patch to autogen.sh to deal with this. Cheers, /Sebastian -- Sebastian Strollo seb(a)tail-f.com Tail-f Systems AB

3 3

tools/dump-xsd.c
by Andrew Hood 05 Sep '06

05 Sep '06

Would you mind renaming the function static int pow( int base, unsigned int exponent ) to something that does not name clash with math.h and libm which have double pow(double x, double y); I changed it to SMIpow to shut up the compiler. You make have some other preference. -- There's no point in being grown up if you can't be childish sometimes. -- Dr. Who

2 2

Ask for some basic usages about Libsmi smidump perl format
by wanderchiou 21 Aug '06

21 Aug '06

Hello, Everyone: I want to SNMP Testing tools to do SNMP conformance test. It needs to use Perl to send the basic/correct SNMP Get, GetNext, GetBulk Messages and create an wrong SNMP Get, GetNext, GetBulk Messages with incorrect fields in SNMP Messages to test SNMP Aget. I need a Perl-based MIB Compiler and MIB Browser(better) to read SMIv1 and SM1v2 syntax. Do you have any suggestions? I am surveying some Perl SNMP tools. (1) Libsmi I know that "libsmi smidump -p 'preload module' -f perl moules" can create Perl format. How to use the Perl format file? Do you have a Perl example to use it or have a document to describe the Perl format? How to integrate into Net-SNMP Perl Module? Is it possible? I note that '-p module' can preload only one module. May I preload many modules in advance? (2) Net-SNMP Perl Module It can send correct SNMP Message only and NetSNMP binary library. It can not send the incorrect SNMP Message and the wrong fields in SNMP Message. Do you know any Perl Package to sen SNMP Msg in Perl only without any additional library installation? Just use Perl Socket or Socket6 to create SNMP Header and SNMP PDU to send get, getnext, getbulk SNMP msgs. (3)How about Net::SNMP? http://search.cpan.org/dist/Net-SNMP/ How to integrate into Net::SNMP? Is it possible? Thank you very much in advance! Best Regards, Wan-Der Chiou ___________________________________________________ 最新版 Yahoo!奇摩即時通訊 7.0，免費網路電話任你打！ http://messenger.yahoo.com.tw/

1 0

Invalid XML from smidump -f xsd (fractionDigits)
by Arndt Jonasson 31 Jul '06

31 Jul '06

[libsmi 0.4.5, and also most recent.] In dump-xsd.c, there is this line: fprintSegment( f, 0, "<xsd:fractionDigits=\"%d\"/>\n", offset ); As I understand XML, it should be: fprintSegment( f, 0, "<xsd:fractionDigits value=\"%d\"/>\n", offset );

2 1

Malformed patterns using -f xsd
by Arndt Jonasson 31 Jul '06

31 Jul '06

I use libsmi 0.4.5. When I have a textual convention like this one: NiceString ::= TEXTUAL-CONVENTION DISPLAY-HINT "1d1d" STATUS current DESCRIPTION "doc" SYNTAX OCTET STRING (SIZE (2)) it gets translated by the -f xsd option into: <xsd:simpleType name="NiceString"> <xsd:annotation> <xsd:documentation> doc </xsd:documentation> <xsd:appinfo> <displayHint>1d1d</displayHint> <lengths> <length min="2" max="2"/> </lengths> </xsd:appinfo> </xsd:annotation> <xsd:restriction base="xsd:string"> <xsd:pattern value="((0|[1-9](([0-9]){0,2}))((0|[1-9](([0-9]){0,2})))"/> </xsd:restriction> </xsd:simpleType> Note here that the pattern is malformed: the first opening parenthesis is not closed. The code in getStrDHType which is responsible I find somewhat complicated, but my current fix is to change the line smiAsprintf( &ret, "%s)", ret ); to smiAsprintf( &ret, "%s))", ret ); This is line 585; the header has * @(#) $Id: dump-xsd.c 2609 2005-07-12 07:44:57Z strauss $ This fix may be in the wrong place, though. A second problem I encountered while debugging the above is that this definition: NiceString ::= TEXTUAL-CONVENTION DISPLAY-HINT "1d1d" STATUS current DESCRIPTION "doc" SYNTAX OCTET STRING (SIZE (2 | 2)) causes smidump to hang. In practice this is not a problem - just fix the SIZE specification in the MIB file.

3 2